Skip to content

Conversation

@pancan21
Copy link

Description

Previous implementation using list of boolean values resulted in ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

I assume using any() instead of all() is the intended behavior.

Motivation and Context

Why is this change required? ValueError when setting td.set_at_()
close #1476

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Not sure how this logical error should be tested. Please help

Previous implementation using list of boolean values resulted in ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

I assume using any() instead of all() is the intended behavior.
@meta-cla
Copy link

meta-cla bot commented Nov 17, 2025

Hi @pancan21!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2025
@meta-cla
Copy link

meta-cla bot commented Nov 17, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pancan21 pancan21 changed the title Change is_diff check to use is_diff.any() [BUG FIX] Change is_diff check to use is_diff.any() Nov 17, 2025
@pancan21 pancan21 changed the title [BUG FIX] Change is_diff check to use is_diff.any() [BugFix] Change is_diff check to use is_diff.any() Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] _td.py uses comparison of lists as truth value without calling any/all

1 participant