Skip to content

[NOMERGE] Migrate TorchRL to tensordict.nn.TensorDictModule #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

[NOMERGE] Migrate TorchRL to tensordict.nn.TensorDictModule #66

merged 1 commit into from
Nov 22, 2022

Conversation

@tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Nov 22, 2022

Description

This PR contains changes to support adoption of tensordict.nn.TensorDictModule in TorchRL. It should not be merged in isolation.

cf. pytorch/rl#700

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2022
@tcbegley tcbegley mentioned this pull request Nov 22, 2022
Merged
vmoens
vmoens approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's merge this

@vmoens vmoens merged commit 32059b4 into main Nov 22, 2022
@tcbegley tcbegley deleted the torchrl-module-fixes branch February 27, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tcbegley @vmoens @facebook-github-bot