Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 11, 2022

This will put all the new dependencies recently added to Windows into the AMI and allow the clean up of Windows conda and pip dependencies

Testing

  • Build the new AMI packer build -var 'skip_create_ami=false' . to generate the new AMI:
us-east-1: ami-09867229e1a23e4a4
us-east-2: ami-0d86430cb9c2aa0a8

@huydhn huydhn self-assigned this Nov 11, 2022
@vercel
Copy link

vercel bot commented Nov 11, 2022

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2022
@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
torchci ⬜️ Ignored (Inspect) Nov 11, 2022 at 2:09AM (UTC)

@huydhn huydhn requested a review from a team November 11, 2022 03:16
@huydhn huydhn marked this pull request as ready for review November 11, 2022 03:22
@huydhn huydhn merged commit 1e8f58a into pytorch:main Nov 11, 2022
@huydhn huydhn deleted the update-windows-dependencies branch November 16, 2022 00:40
kit1980 pushed a commit that referenced this pull request Nov 23, 2022
This will put all the new dependencies recently added to Windows into
the AMI and allow the clean up of Windows conda and pip dependencies

### Testing 

* Build the new AMI `packer build -var 'skip_create_ami=false' .` to
generate the new AMI:

```
us-east-1: ami-09867229e1a23e4a4
us-east-2: ami-0d86430cb9c2aa0a8
```

* Launch canary runners with the new AMI `terraform apply
-target=module.canary_runners`
* Testing on canary https://github.com/pytorch/pytorch-canary/pull/149
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Dec 20, 2022
The new Windows AMI from pytorch/test-infra#1065 is now ready. All Windows pip dependencies are now part of the Windows AMI and can be cleaned up from the CI
Pull Request resolved: #88862
Approved by: https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants