Add docker base push job #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zhouzhuojie
force-pushed
the
add-docker-base-push-job
branch
2 times, most recently
from
81b1d0e to
1ae158f
Compare
seemethere
approved these changes
May 26, 2021
driazati
approved these changes
May 26, 2021
samestep
approved these changes
May 26, 2021
|
|
||
| RUN apt-get update && apt-get upgrade -y && apt-get install -y git python3-dev python3-pip build-essential cmake clang-tidy-11 time | ||
| RUN update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-11 1000 | ||
| RUN pip3 install pyyaml typing_extensions dataclasses No newline at end of file |
There was a problem hiding this comment.
nit but could you add a trailing newline here? :P
There was a problem hiding this comment.
hmm. why didn't it failed quick check?
There was a problem hiding this comment.
because this isn't in pytorch/pytorch
walterddr
approved these changes
May 26, 2021
|
|
||
| RUN apt-get update && apt-get upgrade -y && apt-get install -y git python3-dev python3-pip build-essential cmake clang-tidy-11 time | ||
| RUN update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-11 1000 | ||
| RUN pip3 install pyyaml typing_extensions dataclasses No newline at end of file |
There was a problem hiding this comment.
hmm. why didn't it failed quick check?
zhouzhuojie
force-pushed
the
add-docker-base-push-job
branch
from
1ae158f to
61aa9a4
Compare
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 26, 2021
Summary: This PR introduces a docker base to speed up the `clang-tidy`'s dependencies stage. Originally I was looking into using the native github action cache, but the dependencies are spread across many apt and pip installation places, thus consolidating with a docker image might work better. It shortens the deps installation time from 4min down to 1min by pulling from docker base image. Base image used: pytorch/test-infra#15 ``` FROM nvidia/cuda:10.2-devel-ubuntu18.04 RUN apt-get update && apt-get upgrade -y RUN apt install -y software-properties-common wget RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - RUN apt-add-repository "deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main" RUN apt-add-repository ppa:git-core/ppa RUN apt-get update && apt-get upgrade -y && apt-get install -y git python3-dev python3-pip build-essential cmake clang-tidy-11 RUN update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-11 1000 RUN pip3 install pyyaml typing_extensions dataclasses ``` Previous successful run of clang-tidy: https://github.com/pytorch/pytorch/runs/2671193875?check_suite_focus=true Pull Request resolved: #58964 Reviewed By: samestep Differential Revision: D28712536 Pulled By: zhouzhuojie fbshipit-source-id: 0c48a605efe8574c104da6a0cad1a8b7853ba35e
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: This PR introduces a docker base to speed up the `clang-tidy`'s dependencies stage. Originally I was looking into using the native github action cache, but the dependencies are spread across many apt and pip installation places, thus consolidating with a docker image might work better. It shortens the deps installation time from 4min down to 1min by pulling from docker base image. Base image used: pytorch/test-infra#15 ``` FROM nvidia/cuda:10.2-devel-ubuntu18.04 RUN apt-get update && apt-get upgrade -y RUN apt install -y software-properties-common wget RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - RUN apt-add-repository "deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main" RUN apt-add-repository ppa:git-core/ppa RUN apt-get update && apt-get upgrade -y && apt-get install -y git python3-dev python3-pip build-essential cmake clang-tidy-11 RUN update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-11 1000 RUN pip3 install pyyaml typing_extensions dataclasses ``` Previous successful run of clang-tidy: https://github.com/pytorch/pytorch/runs/2671193875?check_suite_focus=true Pull Request resolved: pytorch#58964 Reviewed By: samestep Differential Revision: D28712536 Pulled By: zhouzhuojie fbshipit-source-id: 0c48a605efe8574c104da6a0cad1a8b7853ba35e
jeanschmidt
added a commit
that referenced
this pull request
Sep 13, 2022
* [WIP] Major rewrite * Improved syntax; * Removed redundancy; * Removed unused branches of the code (including related to organization); * Centralized env's in a config class, so proper mocking/testing can be implemented; files OK: * config.ts * index.ts * gh-auth.ts * fixed runners.ts and improved its tests tests files passing: gh-auth.test.ts kms/index.test.ts config.test.ts runners.test.ts * Passing tests for scale-down * yarn format * rewrite of scale-up, scale-down and lambda * rewrite of scale-up, scale-down and lambda * fixed bugs related to installationId and secrets decrypt Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ci-clang-tidy base docker image to speed up the CI Lint. This shortens 8mins to 4mins.
Previous docker build with PR
GITHUB_TOKENpermission failed at the last step of pushing the image to github container registry, will verify if it works when merged into masterhttps://github.com/pytorch/test-infra/runs/2671207595?check_suite_focus=true
By default, the permissive action's default
GITHUB_TOKENshould be able to write to the github container registry frommasterbranch.https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token