-
Notifications
You must be signed in to change notification settings - Fork 107
[ciflow] remove ciflow/all as an option #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but perhaps we can rephrase the message to avoid classifying contributors into "we" and "people"?
Also, not sure if ciflow/all
also implied ciflow/binaries
. If it were not, then this is one more reason to exclude it
"ciflow/periodic", | ||
"ciflow/all", | ||
"ciflow/android", | ||
"ciflow/binaries", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like "ciflow/binaries" are kept so we should be ok, I thin we need this label.
It did not run binaries, but otherwise the suggested verbiage is probably better :P |
Remove this from the list of supported labels, and provide a message explaining why.
The counterpart to pytorch/test-infra#353, see that PR for more context. [skip ci]
The counterpart to pytorch/test-infra#353, see that PR for more context. [skip ci]
The counterpart to pytorch/test-infra#353, see that PR for more context. [skip ci] Pull Request resolved: #78317 Approved by: https://github.com/janeyx99
Summary: The counterpart to pytorch/test-infra#353, see that PR for more context. [skip ci] Pull Request resolved: #78317 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d98a8148b66fb6f74ce1b437d6bde4f24208bb78 Reviewed By: seemethere Differential Revision: D36783162 Pulled By: suo fbshipit-source-id: be4a0735df8fa3de2d085bbedf52d8d84870f136
Remove this from the list of supported labels, and provide a message
explaining why.