Skip to content

Conversation

suo
Copy link
Member

@suo suo commented May 25, 2022

Remove this from the list of supported labels, and provide a message
explaining why.

@vercel
Copy link

vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
torchci ✅ Ready (Inspect) Visit Preview May 25, 2022 at 11:09PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2022
@suo suo requested review from janeyx99, malfet and seemethere May 25, 2022 21:57
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps we can rephrase the message to avoid classifying contributors into "we" and "people"?

Also, not sure if ciflow/all also implied ciflow/binaries. If it were not, then this is one more reason to exclude it

"ciflow/periodic",
"ciflow/all",
"ciflow/android",
"ciflow/binaries",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "ciflow/binaries" are kept so we should be ok, I thin we need this label.

@suo
Copy link
Member Author

suo commented May 25, 2022

It did not run binaries, but otherwise the suggested verbiage is probably better :P

Remove this from the list of supported labels, and provide a message
explaining why.
@suo suo force-pushed the remove-ciflow-all branch from eaad3b6 to f37127c Compare May 25, 2022 23:08
@suo suo merged commit 4bf7a03 into main May 25, 2022
@suo suo deleted the remove-ciflow-all branch May 25, 2022 23:08
suo added a commit to pytorch/pytorch that referenced this pull request May 25, 2022
The counterpart to pytorch/test-infra#353, see
that PR for more context.

[skip ci]
suo added a commit to pytorch/pytorch that referenced this pull request May 26, 2022
The counterpart to pytorch/test-infra#353, see
that PR for more context.

[skip ci]
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request May 26, 2022
The counterpart to pytorch/test-infra#353, see
that PR for more context.

[skip ci]

Pull Request resolved: #78317
Approved by: https://github.com/janeyx99
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request May 31, 2022
Summary:
The counterpart to pytorch/test-infra#353, see
that PR for more context.

[skip ci]

Pull Request resolved: #78317
Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d98a8148b66fb6f74ce1b437d6bde4f24208bb78

Reviewed By: seemethere

Differential Revision: D36783162

Pulled By: suo

fbshipit-source-id: be4a0735df8fa3de2d085bbedf52d8d84870f136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants