[mergebot] Add ignore current flag #3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Mar 15, 2023
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 17, 2023
The flag is deprecated and is being removed in pytorch/test-infra#3882 Pull Request resolved: #97033 Approved by: https://github.com/huydhn
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 20, 2023
with pytorch/test-infra#3882 Add -ic/--ignore-current flag for merge. It ignores the currently failing checks but will stop when there is a new failure. If there are no pending checks, it fails and tells you to use -f/--force. Doesn't work on ghstacks with more than 1 PR. Pull Request resolved: #96756 Approved by: https://github.com/huydhn
ZainRizvi
reviewed
Mar 21, 2023
Comment on lines
+51
to
+52
| "Merge while ignore the currently failing jobs. If there are no pending checks, use -f/--force " + | ||
| "since this will fail.", |
There was a problem hiding this comment.
"Merge while ignore the currently failing jobs. If there are no pending checks, use -f/--force since this will fail.",
Suggestion: If there are no pending checks, can we not make it fail? Just ignore the currently failed checks instead. It would be nice to get devs to forget we have a -f parameter.
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
The flag is deprecated and is being removed in pytorch/test-infra#3882 Pull Request resolved: pytorch/pytorch#97033 Approved by: https://github.com/huydhn
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
with pytorch/test-infra#3882 Add -ic/--ignore-current flag for merge. It ignores the currently failing checks but will stop when there is a new failure. If there are no pending checks, it fails and tells you to use -f/--force. Doesn't work on ghstacks with more than 1 PR. Pull Request resolved: pytorch/pytorch#96756 Approved by: https://github.com/huydhn
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
The flag is deprecated and is being removed in pytorch/test-infra#3882 Pull Request resolved: pytorch/pytorch#97033 Approved by: https://github.com/huydhn
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
with pytorch/test-infra#3882 Add -ic/--ignore-current flag for merge. It ignores the currently failing checks but will stop when there is a new failure. If there are no pending checks, it fails and tells you to use -f/--force. Doesn't work on ghstacks with more than 1 PR. Pull Request resolved: pytorch/pytorch#96756 Approved by: https://github.com/huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove green and landchecks
with pytorch/pytorch#96756