Hide suppressed bc linter failure on Dr.CI (and mergebot) #4956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Feb 17, 2024
malfet
reviewed
Feb 20, 2024
malfet
reviewed
Feb 20, 2024
malfet
approved these changes
Feb 20, 2024
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 21, 2024
After pytorch/test-infra#4956, mergebot will not block merge for a bc linter failure that has been suppressed. The failure will be ignored instead. This should help mitigate pytorch/test-infra#4938 because the workflow will not be triggered multiple times when labels are attached. Pull Request resolved: #120148 Approved by: https://github.com/clee2000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #4938 where Dr.CI will hide bc linter failures on a PR if the PR has
suppress-bc-linterorsuppress-api-compatibility-checklabels. This is done dynamically whenever Dr.CI is run (periodically and during merge).The only supported use case atm is bc linter.
Testing
pytorch/pytorch#118857 has a bc linter failure that has been suppressed. Running the following curl command locally will update Dr.CI and hide the bc linter failure there.
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118857
Note: Links to docs will display an error until the docs builds have been completed.
✅ You can merge normally! (2 Unrelated Failures)
As of commit af3d1d0f1a787f8f29138637720a14a532809b3c with merge base cf42dd09ca47e293736ebbc80a919b4d53ede0f8 (
):
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
Process completed with exit code 1.test_autograd.py::TestAutograd::test_post_accumulate_grad_hook_gets_cleaned_upThis comment was automatically generated by Dr. CI and updates every 15 minutes.