Skip to content

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Sep 26, 2024

s3 tested by running locally and seeing if it got inserted
dynamo only checked python aws/lambda/clickhouse-replicator-dynamo/test_lambda_function.py to make sure other ingestions didn't break

Also small fix for external_contribution_stats error handler

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 4:31pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
@clee2000 clee2000 changed the title [ch] Set up ingestion for benchmarks tables [ch] Set up ingestion for benchmarks tables and aggregated_test_metrics Sep 26, 2024
@clee2000 clee2000 marked this pull request as ready for review September 26, 2024 21:27
@clee2000 clee2000 requested a review from a team September 26, 2024 21:28
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000 clee2000 merged commit 2f82232 into main Sep 27, 2024
@clee2000 clee2000 deleted the csl/ch_benchmarks branch September 30, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants