updated to IMDSv2 #5783
Merged
updated to IMDSv2 #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
ZainRizvi
approved these changes
Oct 18, 2024
| 2024-07-08T16:51:04.0872992Z [36;1m echo "Runner is from Google Cloud Platform, No info on ec2 metadata"[0m | ||
| 2024-07-08T16:51:04.0873605Z [36;1m else[0m | ||
| 2024-07-08T16:51:04.0874108Z [36;1m curl -fsSL "http://169.254.169.254/latest/meta-data/${category}"[0m | ||
| 2024-07-08T16:51:04.0874108Z [36;1m curl -H "X-aws-ec2-metadata-token: $(curl -s -X PUT "http://169.254.169.254/latest/api/token" -H "X-aws-ec2-metadata-token-ttl-seconds: 30")" -fsSL "http://169.254.169.254/latest/meta-data/${category}"[0m |
Contributor
There was a problem hiding this comment.
This is log now historically inaccurate, lol
Contributor
Author
There was a problem hiding this comment.
reverted the log change ;)
| }) | ||
| // convert these two curls: | ||
| // curl -H "X-aws-ec2-metadata-token: $(curl -s -X PUT "http://169.254.169.254/latest/api/token" -H "X-aws-ec2-metadata-token-ttl-seconds: 30")" -fsSL "http://169.254.169.254/latest/meta-data/${category}" | ||
| const tokenResponse = await http.put( |
Contributor
There was a problem hiding this comment.
this bit could be tested by identifying a workflow that uses it and modifying the reference to point to this PR's branch. Let me know if you need help with that
Contributor
Author
There was a problem hiding this comment.
tested on pytorch/pytorch#139330 - seems to work: https://github.com/pytorch/pytorch/actions/runs/11602944927/job/32308974862?pr=139330#step:6:27 prints the instance id as url
wdvr
added a commit
that referenced
this pull request
Nov 1, 2024
this is a follow up on PR #5783 that enabled IMDSv2. We're about to remove support for IMDSv1 on our AWS account globally This is part of an effort to move all our calls across all pytorch repos to v2. See also: pytorch/FBGEMM#3297 pytorch/pytorch#138286 meta-pytorch/torchsnapshot#180 meta-pytorch/torchrec#2532 meta-pytorch/torcheval#210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.