-
Notifications
You must be signed in to change notification settings - Fork 107
[file report] upload costs to file on s3 #7050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
fc18637 to
7cdb8dc
Compare
| return config | ||
|
|
||
|
|
||
| def get_ec2_instance_for_label(label: str) -> dict[str, Optional[str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this wouldn't work with H100 and teams are using this nowadays to run tests, e.g. https://github.com/pytorch/pytorch/blob/main/.github/workflows/h100-symm-mem.yml. Handling that is probably out of scope, but it's something we want to keep in mind I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, this seems like an expected setup anyway because MacOS is also not here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure how to calculate h100 or mac cost atm since if I understand correctly, it's a reservation so there isn't really a per hour or per second cost
7cdb8dc to
833dd30
Compare
I want the pricing information for each runner by calling the API
basically caches the data on s3
the file looks like https://ossci-metrics.s3.us-east-1.amazonaws.com/ec2_pricing.json.gz