[binaries] metadata lambda to delete existing metadata #7359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
clee2000
changed the title
zxiiro
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete previous metadata when new wheel is uploaded
This way, if the lambda fails, there will not be stale data
Testing:
checked on something that doesn't have a metadata file already
checked on something that does have metadata file already
I think it might be better if the metadata is uploaded with the binary, maybe add some s3 metadata to the binary and whl to show theyre in sync, then the lambda deletes metadata whose sync tag doesn't match the binary's
If the binary is uploaded manually, then it there won't be metadata, but I'm not sure how often this happens. Also domains that do custom stuff? but idk how often this happens either. Also additional packages that get uploaded to the index?