-
Notifications
You must be signed in to change notification settings - Fork 107
Not call list util metadata in workflow box #7503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| let shouldFetch = workflowId && jobId; | ||
| let { data, error } = useSWRImmutable( | ||
| `/api/utilization/${workflowId}/${jobId}/${attempt}`, | ||
| shouldFetch ? `/api/utilization/${workflowId}/${jobId}/${attempt}` : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block the undefined call even from the call side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can still just curl from command line or something if they want tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yah, i can add some auth token for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
| `/api/utilization/${workflowId}/${jobId}/${attempt}`, | ||
| shouldFetch | ||
| ? `/api/job_utilization/${workflowId}/${jobId}/${attempt}` | ||
| : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to pass in the authorization token here? I mean it does block the api, but now I think it blocks for every one
we run into some memory issues, so improve some utilization queries: