Rewrite scaleDown to fix a series of bugs #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…topped, and bad ordering of finishing runners
…nschmidt/fix_scaleDown_runnerSort
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
seemethere
approved these changes
Oct 10, 2022
Member
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
LGTM, want to get a second review from @izaitsevfb
izaitsevfb
reviewed
Oct 11, 2022
...aform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-down.test.ts
Outdated
Show resolved
Hide resolved
izaitsevfb
reviewed
Oct 11, 2022
...aform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-down.test.ts
Outdated
Show resolved
Hide resolved
izaitsevfb
reviewed
Oct 11, 2022
| { | ||
| runnerType: 'ignore-no-org-no-repo', | ||
| instanceId: '001', | ||
| launchTime: dateRef |
Contributor
There was a problem hiding this comment.
nit:
dateRef
.clone()
.subtract(minimumRunningTimeInMinutes + x, 'minutes')
.toDate()
can be extracted as a reusable local function.
izaitsevfb
reviewed
Oct 11, 2022
| expect(mockedTerminateRunner).toBeCalledTimes(6); | ||
| { | ||
| /* eslint-disable-next-line @typescript-eslint/no-unused-vars */ | ||
| const { awsR, ghR } = getRunnerPair('keep-lt-min-no-ghrunner-no-ghr-02'); |
Contributor
There was a problem hiding this comment.
Why not do const { awsR } = getRunnerPair(...) to avoid lint warning?
izaitsevfb
approved these changes
Oct 12, 2022
Contributor
izaitsevfb
left a comment
izaitsevfb
left a comment
There was a problem hiding this comment.
I've added a bunch of comments, they are basically nits, mostly FYI, something to consider in the future. Overall everything looks pretty good, the code is clean and easy to understand.
…nschmidt/fix_scaleDown_runnerSort
…culate the amount of instances to keep free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On scaleDown:
minAvailableRunnersrunners;