Lint actions #89
Merged
Lint actions #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
driazati
force-pushed
the
lintact
branch
3 times, most recently
from
7f4d170 to
066b5b2
Compare
driazati
force-pushed
the
lintact
branch
2 times, most recently
from
9084363 to
2ececfe
Compare
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 29, 2021
Summary: This adds a linter for our GitHub actions. When a GitHub Actions workflow has an invalid definition, GitHub doesn't queue the job and doesn't report it as failed, so these can be hard to detect with the usual tools. This adds an explicit job to check if our workflow YAMLs are valid using [https://github.com/rhysd/actionlint](https://github.com/rhysd/actionlint). We deployed a similar check in pytorch/test-infra [here](pytorch/test-infra#89). This PR enables the linter and fixes all the issues it complained about (it did already catch one bug where we were leaving `CIRCLE_BRANCH` blank when uploading binary size) Pull Request resolved: #62364 Reviewed By: zhouzhuojie Differential Revision: D29973928 Pulled By: driazati fbshipit-source-id: 83b365e98fd6cbdcd75eeb44daf1be1c89056f8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates https://github.com/rhysd/actionlint which checks workflow files for syntactic validity plus some extra GitHub Action specific semantics. If it sees that ShellCheck is installed it will also pull out each
run:block and check it, so this integrates that as well.Example failure: https://github.com/pytorch/test-infra/runs/3186195613
We can copy-paste this pretty much verbatim into pytorch/pytorch since actionlint finds workflow files automatically.