Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Rename ChannelIndex to column_index_t (#1811) #388

Closed
wants to merge 1 commit into from
Closed

Rename ChannelIndex to column_index_t (#1811) #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csrc/velox/column.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,12 +770,12 @@ class RowColumn : public BaseColumn {
velox::vector_size_t length)
: BaseColumn(other, offset, length) {}

std::unique_ptr<BaseColumn> childAt(velox::ChannelIndex index) {
std::unique_ptr<BaseColumn> childAt(velox::column_index_t index) {
auto dataPtr = _delegate.get()->as<velox::RowVector>();
return createColumn(dataPtr->childAt(index), _offset, _length);
}

void setChild(velox::ChannelIndex index, const BaseColumn& new_child) {
void setChild(velox::column_index_t index, const BaseColumn& new_child) {
auto dataPtr = _delegate.get()->as<velox::RowVector>();
dataPtr->children()[index] = new_child._delegate;
}
Expand Down