This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Fix arrow schema conversion for complex types (#1857) #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37356848 |
Summary: Pull Request resolved: pytorch#399 X-link: facebookincubator/velox#1857 1. Use `List` instead of `LargeList` because `vector_size_t` is 32 bits large. 2. Fix the conversion of `Map`; arrow requires an extra layer of struct type between the map type and key-value types. Reviewed By: pedroerp Differential Revision: D37356848 fbshipit-source-id: 237428cc315466a74a4285445dfc925a6cd2729d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37356848 |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jul 6, 2022
Summary: X-link: pytorch/torcharrow#399 Pull Request resolved: #1857 1. Use `List` instead of `LargeList` because `vector_size_t` is 32 bits large. 2. Fix the conversion of `Map`; arrow requires an extra layer of struct type between the map type and key-value types. Reviewed By: pedroerp Differential Revision: D37356848 fbshipit-source-id: 6289708cdd207c27c2bb30fe4c4827a65acd7e6d
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Summary: Pull Request resolved: #399 X-link: facebookincubator/velox#1857 1. Use `List` instead of `LargeList` because `vector_size_t` is 32 bits large. 2. Fix the conversion of `Map`; arrow requires an extra layer of struct type between the map type and key-value types. Reviewed By: pedroerp Differential Revision: D37356848 fbshipit-source-id: 6289708cdd207c27c2bb30fe4c4827a65acd7e6d
wenleix
pushed a commit
that referenced
this pull request
Jul 16, 2022
Summary: Pull Request resolved: #399 X-link: facebookincubator/velox#1857 1. Use `List` instead of `LargeList` because `vector_size_t` is 32 bits large. 2. Fix the conversion of `Map`; arrow requires an extra layer of struct type between the map type and key-value types. Reviewed By: pedroerp Differential Revision: D37356848 fbshipit-source-id: 6289708cdd207c27c2bb30fe4c4827a65acd7e6d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#1857
Listinstead ofLargeListbecausevector_size_tis 32 bits large.Map; arrow requires an extra layer of struct type between the map type and key-value types.Differential Revision: D37356848