This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Remove unused methods _nlargest, _nsmallest, _nunique from icolumn, numerical_column_cpu, and dataframe_cpu (#411) #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37503197 |
andrewaikens87
added a commit
to andrewaikens87/torcharrow
that referenced
this pull request
Jun 29, 2022
…l_column_cpu, and dataframe_cpu (pytorch#415) Summary: Pull Request resolved: pytorch#415 Removes unused private methods in icolumn.py bringing code coverage to 79.2%. Differential Revision: D37503197 fbshipit-source-id: fd8dfe709963b80bb53998d9f9a3da30ed9897dc
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37503197 |
andrewaikens87
force-pushed
the
export-D37503197-to-fbsync
branch
from
c0fe54a to
c005b9a
Compare
Differential Revision: D37289878 fbshipit-source-id: 90e9600eb769eec7341f611561be59f7c005e66d
…l_column_cpu, and dataframe_cpu (pytorch#415) Summary: Pull Request resolved: pytorch#415 Removes unused private methods in icolumn.py bringing code coverage to 79.2%. Reviewed By: wenleix Differential Revision: D37503197 fbshipit-source-id: 44e7ca7fbbd220fd100150f3a974c4a98ae93d39
andrewaikens87
force-pushed
the
export-D37503197-to-fbsync
branch
from
c005b9a to
40dd339
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37503197 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #411
Removes unused private methods in icolumn.py bringing code coverage to 79.2%.
Differential Revision: D37503197