This repository was archived by the owner on Nov 1, 2024. It is now read-only.
refactor generic udf dispatch methods in variadic form #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37623365 |
kedar-parab
added a commit
to kedar-parab/torcharrow
that referenced
this pull request
Jul 12, 2022
Summary: Pull Request resolved: pytorch#433 refactor generic udf dispatch [methods](https://github.com/pytorch/torcharrow/blob/main/csrc/velox/column.h#L370-L390) to have one genericUDF method Reviewed By: wenleix Differential Revision: D37623365 fbshipit-source-id: 02986cf45c456fba0048ec0ea647677bb0444e0b
kedar-parab
force-pushed
the
export-D37623365-to-fbsync
branch
from
650e3da to
a6feb1c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37623365 |
Differential Revision: https://www.internalfb.com/diff/D37622663?entry_point=27 fbshipit-source-id: 13c6db793a70eb553591eb49bb1b239f46549625
Summary: Pull Request resolved: pytorch#433 refactor generic udf dispatch [methods](https://github.com/pytorch/torcharrow/blob/main/csrc/velox/column.h#L370-L390) to have one genericUDF method Reviewed By: wenleix Differential Revision: D37623365 fbshipit-source-id: e253a3f1e45401c0f18ca8c8b3f494e155836525
kedar-parab
force-pushed
the
export-D37623365-to-fbsync
branch
from
a6feb1c to
08c3588
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37623365 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Summary: Pull Request resolved: #433 refactor generic udf dispatch [methods](https://github.com/pytorch/torcharrow/blob/main/csrc/velox/column.h#L370-L390) to have one genericUDF method Reviewed By: wenleix Differential Revision: D37623365 fbshipit-source-id: 175267c14ad25219c925cad724f9dd4818faa8c1
wenleix
pushed a commit
that referenced
this pull request
Jul 16, 2022
Summary: Pull Request resolved: #433 refactor generic udf dispatch [methods](https://github.com/pytorch/torcharrow/blob/main/csrc/velox/column.h#L370-L390) to have one genericUDF method Reviewed By: wenleix Differential Revision: D37623365 fbshipit-source-id: 175267c14ad25219c925cad724f9dd4818faa8c1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: refactor generic udf dispatch methods to have one genericUDF method
Differential Revision: D37623365