Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Conversation

@bearzx
Copy link
Contributor

@bearzx bearzx commented Jul 15, 2022

tsia. We previously removed the doc deploy from "CI on push" because we didn't want to update the doc on every PR push, this PR recreates the doc push in nightly build workflows.

Did some minor cleanup as well.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2022
@bearzx bearzx requested a review from wenleix July 15, 2022 22:10
@bearzx bearzx marked this pull request as ready for review July 15, 2022 22:10
Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- name: Install the freshly uploaded TorchArrow
run: |
pip install --pre torcharrow -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: does this guarantee to download the just uploaded TA nightly? ;)

cc @ejguan , @NivekT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. I believe it will take a few minutes for the just uploaded wheels becoming available from the link. Why not just install from your local wheel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that's probably better, lemme tweak it that way.

@bearzx bearzx force-pushed the bearzx-dev-infra branch 4 times, most recently from c8a010c to dc16d54 Compare July 16, 2022 01:06
@bearzx bearzx force-pushed the bearzx-dev-infra branch from dc16d54 to bcd5a17 Compare July 16, 2022 04:34
@bearzx bearzx merged commit 22ed674 into main Jul 16, 2022
@bearzx bearzx deleted the bearzx-dev-infra branch July 16, 2022 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants