This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Pass not nullable context and results by reference (#2367) #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38946493 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 24, 2022
…#479) Summary: X-link: pytorch/torcharrow#479 Pull Request resolved: facebookincubator#2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Differential Revision: D38946493 fbshipit-source-id: 7c339da7300cc4bade9c92205ce8c47061b2ff28
Summary: Pull Request resolved: pytorch#479 X-link: facebookincubator/velox#2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: 0f5b0b3b926d5f12a56d35a57a9549dd3393a526
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38946493 |
laithsakka
force-pushed
the
export-D38946493-to-fbsync
branch
from
14e42a9 to
c0cdc3b
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 26, 2022
…#479) Summary: X-link: pytorch/torcharrow#479 Pull Request resolved: facebookincubator#2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: bb1a06a4724dc5c54fa4d0e31780c43ca7746662
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Aug 26, 2022
Summary: X-link: pytorch/torcharrow#479 Pull Request resolved: #2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: ce4e2714332cb13e9b0c6a9a35e93fcd96ae038a
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
Summary: Pull Request resolved: #479 X-link: facebookincubator/velox#2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: ce4e2714332cb13e9b0c6a9a35e93fcd96ae038a
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#2367
Those are always assumed not null and de-referenced with out
checking, hence passing them by reference is more suitable.
Differential Revision: D38946493