Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Nov 18, 2024

1 - Complete markup for testing
2 - add test extraction from multimodal.md to run-docs
3 - run generated test from git workflows

Notes:
a - need to use actual llama model because stories models do not support multimodal inputs
b - this will require HF access tokens which are currently not necessary because stories models can be downloaded without tokens
c - use of HF access tokens are currently not used (?), so might require additional setup

Complete markup for testing
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1382

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4c4011c with merge base 5da240a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 18, 2024
Add ability to run on docs/multimodal.md
@mikekgfb mikekgfb changed the title Update multimodal.md Add multimodal to possible tests Nov 18, 2024
@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Nov 19, 2024

Thanks for starting MM testing, we’ll need to polish to make this test useful (failing silently unrelated to MM I think)

Let’s find a good solution to testing 11b prior to landing to avoid a false sense of confidence

cc: @Gasoonjia

@byjlw byjlw merged commit edc2cfb into pytorch:main Nov 19, 2024
54 checks passed
vmpuri pushed a commit that referenced this pull request Feb 4, 2025
* Update multimodal.md

Complete markup for testing

* Update run-docs

Add ability to run on docs/multimodal.md

* Update run-readme-pr.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants