Enable torch.nn.Parameter to be dictionary key #579
Conversation
|
Overall, looks good to me. Once you have optimizers working, would you be interested in adding optimizers in benchmarks/common.py so that we can test torchbench and huggingface models with optimizers? |
Let me see if there are other higher priority follow ups that are needed from the distributed team but I think this would be a good continuation of this. |
|
@mlazos , this PR triggers an assertion in several torchbench tests, e.g. |
I'll take a look at the asserts and and either have a followup fix or revert if necessary |
Summary: In #579, the torchbench CI run hits an ssertion but didn't report failure on that. It will be helpful to raise AssertionError at this active development stage.
Summary: In #579, the torchbench CI run hits an ssertion but didn't report failure on that. It will be helpful to raise AssertionError at this active development stage.
Summary: In #579, the torchbench CI run hits an ssertion but didn't report failure on that. It will be helpful to raise AssertionError at this active development stage.
Summary: In #579, the torchbench CI run hits an ssertion but didn't report failure on that. It will be helpful to raise AssertionError at this active development stage.
5 participants
This functionality is needed to trace through optimizers.
Summary of changes