[DeepSeek] Add option for torch._group_mm
#1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
lessw2020
reviewed
Apr 10, 2025
| # 2. "symm_mem" (see `setup_symm_mem` below) | ||
| shuffle_method = "torch_all_to_all" | ||
| # Group GEMM method, "torch" or "torchao" | ||
| group_mm = "torch" |
Contributor
There was a problem hiding this comment.
tiny nit but I like just having selectable options next to the item, like how we do it in the toml:
group_mm = "torch" # ["torch", "torchao"]
lessw2020
approved these changes
Apr 10, 2025
Contributor
lessw2020
left a comment
lessw2020
left a comment
There was a problem hiding this comment.
cool, thanks for integrating this as another grouped gemm option!
note - the adamw aspect for torch._grouped_mm hasn't been resolved yet but hopefully before we get to the training loop.
This was referenced Apr 12, 2025
tianyu-l
added a commit
that referenced
this pull request
Apr 12, 2025
as titled also fixing a breakage caused by #1086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two options for Group GEMM now:
Option 1:
torch._group_mmOption 2:
grouped_gemm_forward(torchao)