Skip to content

[CI] Disable Async TP CI #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

[CI] Disable Async TP CI #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52667b3
[CI] Disable Async TP CI
fegin Sep 25, 2025
eccef5d
Allow an easy way to disable tests.
fegin Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration_tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class OverrideDefinitions:
test_descr: str = "default"
test_name: str = "default"
ngpu: int = 4
disabled: bool = False

def __repr__(self):
return self.test_descr
44 changes: 23 additions & 21 deletions tests/integration_tests/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,18 @@ def build_features_test_list() -> list[OverrideDefinitions]:
"2d_compile",
),
# TODO: re-enable this test once the async TP CI issue is fixed
# OverrideDefinitions(
# [
# [
# "--compile.enable",
# "--parallelism.tensor_parallel_degree 2",
# "--parallelism.enable_async_tensor_parallel",
# ],
# ],
# "2D async TP compile",
# "2d_asynctp_compile",
# ),
OverrideDefinitions(
[
[
"--compile.enable",
"--parallelism.tensor_parallel_degree 2",
"--parallelism.enable_async_tensor_parallel",
],
],
"2D async TP compile",
"2d_asynctp_compile",
disabled=True,
),
OverrideDefinitions(
[
[
Expand Down Expand Up @@ -432,16 +433,17 @@ def build_features_test_list() -> list[OverrideDefinitions]:
"cpu_offload+opt_in_bwd+TP+DP+CP",
ngpu=8,
),
# OverrideDefinitions(
# [
# [
# "--memory_estimation.enable",
# ]
# ],
# "FSDP2 Memory Tracking and Estimation",
# "fsdp2_memory_estimation",
# ngpu=2,
# ),
OverrideDefinitions(
[
[
"--memory_estimation.enable",
]
],
"FSDP2 Memory Tracking and Estimation",
"fsdp2_memory_estimation",
ngpu=2,
disabled=True,
),
OverrideDefinitions(
[
[
Expand Down
4 changes: 4 additions & 0 deletions tests/integration_tests/h100.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def build_h100_tests_list() -> list[OverrideDefinitions]:
same root config file.
"""
integration_tests_flavors = [
# TODO: re-enable this test once the async TP issue is fixed
OverrideDefinitions(
[
[
Expand All @@ -29,6 +30,7 @@ def build_h100_tests_list() -> list[OverrideDefinitions]:
],
"2D async TP compile",
"2d_asynctp_compile",
disabled=True,
),
OverrideDefinitions(
[
Expand All @@ -41,6 +43,7 @@ def build_h100_tests_list() -> list[OverrideDefinitions]:
"Float8 test",
"float8",
),
# TODO: re-enable this test once the async TP issue is fixed
OverrideDefinitions(
[
[
Expand All @@ -57,6 +60,7 @@ def build_h100_tests_list() -> list[OverrideDefinitions]:
"FSDP+async TP+PP+torch.compile+Float8",
"fsdp+tp+cp+compile+float8",
ngpu=8,
disabled=True,
),
OverrideDefinitions(
[
Expand Down
3 changes: 3 additions & 0 deletions tests/integration_tests/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ def run_tests(args, test_list: list[OverrideDefinitions]):
if args.test_name != "all" and test_flavor.test_name != args.test_name:
continue

if test_flavor.disabled:
continue

# Check if we have enough GPUs
if args.ngpu < test_flavor.ngpu:
logger.info(
Expand Down
25 changes: 13 additions & 12 deletions torchtitan/experiments/simple_fsdp/tests/integration_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,19 @@ def build_simple_fsdp_test_list() -> list[OverrideDefinitions]:
"2d",
),
# TODO: re-enable this test once the async TP issue is fixed
# OverrideDefinitions(
# [
# [
# "--model.name simple_fsdp",
# "--compile.enable",
# "--parallelism.tensor_parallel_degree 2",
# "--parallelism.enable_async_tensor_parallel",
# ],
# ],
# "2D async TP",
# "2d_asynctp",
# ),
OverrideDefinitions(
[
[
"--model.name simple_fsdp",
"--compile.enable",
"--parallelism.tensor_parallel_degree 2",
"--parallelism.enable_async_tensor_parallel",
],
],
"2D async TP",
"2d_asynctp",
disabled=True,
),
OverrideDefinitions(
[
[
Expand Down