Skip to content

Add simpleFSDP numerics test to CI #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Add simpleFSDP numerics test to CI #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/integration_test_8gpu_flux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ on:
branches: [ main ]
paths:
- 'torchtitan/experiments/flux/**'
- '.github/workflows/integration_test_8gpu_flux.yaml'
pull_request:
paths:
- 'torchtitan/experiments/flux/**'
- '.github/workflows/integration_test_8gpu_flux.yaml'

concurrency:
group: unit-test${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/integration_test_8gpu_simple_fsdp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ on:
branches: [ main ]
paths:
- 'torchtitan/experiments/simple_fsdp/**'
- '.github/workflows/integration_test_8gpu_simple_fsdp.yaml'
pull_request:
paths:
- 'torchtitan/experiments/simple_fsdp/**'
- '.github/workflows/integration_test_8gpu_simple_fsdp.yaml'
schedule:
# Runs every 12 hours
- cron: '0 */12 * * *'
Expand Down Expand Up @@ -49,3 +51,6 @@ jobs:

mkdir artifacts-to-be-uploaded
python -m torchtitan.experiments.simple_fsdp.tests.integration_tests artifacts-to-be-uploaded --ngpu 8

# Run the numerics unit tests of SimpleFSDP
torchrun --nproc-per-node=8 -m pytest torchtitan/experiments/simple_fsdp/tests/test_numerics.py -v
2 changes: 2 additions & 0 deletions .github/workflows/integration_test_8gpu_torchft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ on:
branches: [ main ]
paths:
- 'torchtitan/components/ft.py'
- '.github/workflows/integration_test_8gpu_torchft.yaml'
pull_request:
paths:
- 'torchtitan/components/ft.py'
- '.github/workflows/integration_test_8gpu_torchft.yaml'
schedule:
# Runs every 6 hours
- cron: '0 */6 * * *'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/integration_test_8gpu_vlm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ on:
branches: [ main ]
paths:
- 'torchtitan/experiments/vlm/**'
- '.github/workflows/integration_test_8gpu_vlm.yaml'
pull_request:
paths:
- 'torchtitan/experiments/vlm/**'
- '.github/workflows/integration_test_8gpu_vlm.yaml'
schedule:
# Runs every 12 hours
- cron: '0 */12 * * *'
Expand Down
Loading