Skip to content

[Compiler Toolkit] Avoid DTensorize BlockMask for FlexAttention #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

[Compiler Toolkit] Avoid DTensorize BlockMask for FlexAttention #1952

merged 1 commit into from
Oct 28, 2025

Conversation

@SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 28, 2025 

    # TODO: When using flex_attention, BlockMask would show up in kwargs,
    # and it's unclear how to convert it to DTensor. If I use to_dtensor,
    # it would fail with Dynamo Error: P2011360347
    # dt_kwargs = tree_map(to_dtensor, kwargs)

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 28, 2025
@SherlockNoMad SherlockNoMad merged commit db47630 into main Oct 28, 2025
4 checks passed
jquesnelle pushed a commit to NousResearch/torchtitan that referenced this pull request Nov 10, 2025
@SherlockNoMad @jquesnelle
[Compiler Toolkit] Avoid DTensorize BlockMask for FlexAttention (pyto…
51fff9e 
…rch#1952)

```
    # TODO: When using flex_attention, BlockMask would show up in kwargs,
    # and it's unclear how to convert it to DTensor. If I use to_dtensor,
    # it would fail with Dynamo Error: P2011360347
    # dt_kwargs = tree_map(to_dtensor, kwargs)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiming0416 yiming0416 yiming0416 approved these changes

@fegin fegin Awaiting requested review from fegin

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SherlockNoMad @yiming0416