Skip to content

Fix the error message of maybe_enable_async_tp() #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2025
Merged

Fix the error message of maybe_enable_async_tp() #2011

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc858af
Update
fegin Nov 10, 2025
f352b69
Update (base update)
fegin Nov 10, 2025
68dc6d4
Update
fegin Nov 11, 2025
b8c511b
Update (base update)
fegin Nov 11, 2025
265cefb
Update
fegin Nov 11, 2025
8b69ab8
Update (base update)
fegin Nov 11, 2025
5aea0d3
Update
fegin Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchtitan/distributed/tensor_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ def maybe_enable_async_tp(job_config: JobConfig, tp_mesh: DeviceMesh):
return

if not (job_config.compile.enable and "model" in job_config.compile.components):
raise RuntimeError("Async TP requires --training.compile")
raise RuntimeError(
"Async TP requires 'model' in --compile.components and --compile.enable"
)

from torch.distributed._symmetric_memory import enable_symm_mem_for_group

Expand Down
Loading