added KFP adapter for new torchx.specs.api interface #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary:
This creates a KFP adapter for the new specs interface.
```
import torchx.specs.api as torchx
from kfp import compiler, components, dsl
app = torchx.Application(...)
kfp_copy: Callable = component_from_app(app)
def pipeline() -> dsl.PipelineParam:
a = kfp_copy()
b = kfp_copy()
b.after(a)
return b
compiler.Compiler().compile(pipeline, "pipeline.zip")
```
Pull Request resolved: meta-pytorch/torchx#10
Differential Revision: D28658161
Pulled By: d4l3k
fbshipit-source-id: 33e344314ba5e1671c81f929e4a7e885b510e13a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28658161 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2021
…mpared to platform009's isort Summary: `isort==5.8.0` produces different sorting order compared to platform009's `isort` (not sure which version is used with platform009 but `isort==4.3.21` is the one we used to use for `pytorch/elastic` which produces consistent results to our internal `arc f`. This should fix linter failures for both: 1. #12 2. #10 Reviewed By: d4l3k Differential Revision: D28669450 fbshipit-source-id: 8ead84f96d2ef2d0c01ddaba2ce513c78f7966f3
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a KFP adapter for the new specs interface.