Skip to content

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented May 27, 2021

This adds support for image_type=docker. Image fetchers have been renamed to image providers as docker needs a special CLI command in order to run the docker container.

To select docker:

torchx run --scheduler local --scheduler_args image_type=docker echo.torchx --image pytorch/pytorch:latest

Test plan:

pyre
python setup.py test -s torchx.schedulers
python torchx/cli/main.py run --scheduler local --scheduler_args image_type=docker echo.torchx --image pytorch/pytorch:latest

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2021
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@d4l3k merged this pull request in 322a465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants