kfp integration test #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
kfpint
branch
4 times, most recently
from
a04973e to
b715c45
Compare
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a KFP integration test
This is a bit weird since KFP doesn't have a good way to do programmatic API access on AWS. We end up login in using the KFP cluster username/password and passing the cookie to the KFP client as endorsed by the docs.
Secrets are only provided for PRs that are run from the main repo as a branch and not forks so this will fail on forked PRs.
Test plan:
http://5ab6bab9-istiosystem-istio-2af2-1926929629.us-west-2.elb.amazonaws.com/_/pipeline/#/runs/details/f7c56bef-909e-4660-b4c7-eeef486b224f