Add log_path to TorchXRunner #382
Conversation
Summary: Currently we have to use a fixed parameter to specify "log_path" (see https://colab.research.google.com/drive/1kOKw5ddweQGmtyADoXfp-xoVdqvRBWV_?usp=sharing#scrollTo=kH0XT8nBJwkC). This way we'll be able to pass it to the TorchXRunner directly, which is more natural. See test plan in notebook. Differential Revision: D33979622 fbshipit-source-id: fe293b592c43dcf65ca2310814da9ee39d6eaaaa
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33979622 |
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 94.70% 94.67% -0.03%
==========================================
Files 63 63
Lines 3359 3362 +3
==========================================
+ Hits 3181 3183 +2
- Misses 178 179 +1
Continue to review full report at Codecov.
|
|
Hi @ldworkin! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
2 participants
Summary: Currently we have to use a fixed parameter to specify "log_path" (see https://colab.research.google.com/drive/1kOKw5ddweQGmtyADoXfp-xoVdqvRBWV_?usp=sharing#scrollTo=kH0XT8nBJwkC). This way we'll be able to pass it to the TorchXRunner directly, which is more natural. See test plan in notebook.
Differential Revision: D33979622