Skip to content

fix len greedy search #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix len greedy search #2215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1bc6c
fix len greedy search
vinhtran2611 Feb 23, 2023
cb49585
Merge branch 'main' into main
Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions beginner_source/translation_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def greedy_decode(model, src, src_mask, max_len, start_symbol):

memory = model.encode(src, src_mask)
ys = torch.ones(1, 1).fill_(start_symbol).type(torch.long).to(DEVICE)
for i in range(max_len-1):
for i in range(max_len):
memory = memory.to(DEVICE)
tgt_mask = (generate_square_subsequent_mask(ys.size(0))
.type(torch.bool)).to(DEVICE)
Expand All @@ -371,7 +371,8 @@ def greedy_decode(model, src, src_mask, max_len, start_symbol):
torch.ones(1, 1).type_as(src.data).fill_(next_word)], dim=0)
if next_word == EOS_IDX:
break
return ys
# Return the target sequence without the start symbol
return ys[:, 1:]


# actual function to translate input sentence into target language
Expand Down