OxfordIIITPet dataset #5116
Merged
OxfordIIITPet dataset #5116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit f248e70 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
14 tasks
NicolasHug
reviewed
Jan 5, 2022
There was a problem hiding this comment.
Thanks a lot @pmeier , I made a few comments below, LMK what you think.
When running the tests locally I get a bunch of warnings about files not being closed, e.g.
/Users/nicolashug/dev/vision/test/datasets_utils.py:163: ResourceWarning: unclosed file <_io.BufferedReader name='/var/folders/s_/440yv1k94yz4py2hr4l06qqc0000gn/T/tmpv6brn28c/oxford-iiit-pet/annotations/trimaps/Abyssinian_1.png'>
This could be related to the windows failures we're observing?
NicolasHug
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Thanks a lot @pmeier , LGTM! I don't see the warnings anymore so I assume the windows CI will go green :)
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
Summary: * add prototype dataset for oxford-iiit-pet * add old-style dataset * add tests * fix mypy * fix test * remove properties and use pathlib * target_type to target_types * move target annotation * add docstring * fix test Reviewed By: sallysyw Differential Revision: D33479273 fbshipit-source-id: ecd1dd6b6271328ce485e28e6fcb5d2856627fb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5108.
cc @pmeier @bjuncek