Preparing binary builds #2011
Preparing binary builds #2011
Conversation
.circleci/config.yml
Outdated
| description: "version number of release binary; by default, build a nightly" | ||
| type: string | ||
| default: "" | ||
| default: "0.5.1" |
There was a problem hiding this comment.
Why just a bump in patch version? Is there only bug fixes within this release?
There was a problem hiding this comment.
There will be no major new features in this release, so I think it might be better to make it a minor release.
But given that we haven't had a 1.0 release of torchvision, we have been using the patch numbering for minor releases. At some point we should decide when to cut the 1.0.0 release and do proper MAJOR.MINOR.PATCH versioning though
|
Oh right, the This should be remedied in pytorch/pytorch#35309, going to see if we can fix this in RC2 |
|
Do we need to do the release for Windows? |
|
@peterjc123 yes, we need to do a release for Windows as well, I just saw that you opened a PR for it, thanks! |
|
@fmassa Which branch should be used? |
Codecov Report
@@ Coverage Diff @@
## v0.5.1 #2011 +/- ##
======================================
Coverage 0.48% 0.48%
======================================
Files 92 92
Lines 7407 7407
Branches 1128 1128
======================================
Hits 36 36
Misses 7358 7358
Partials 13 13 Continue to review full report at Codecov.
|
|
@peterjc123 we are going to be using branch v0.5.1, although the release will be 0.6.0, which I agree it's confusing. Let me know if you think creating a new branch named |
|
@fmassa No problem. I think it's okay. BTW, please tell me when do you need the release. |
|
@peterjc123 thanks! I'll let you know, I'm currently fixing a bug and I'll let you know when everything is ready |
4 participants
No description provided.