Skip to content

[ao_migration] torchvision: torch.quantization -> torch.ao.quantization #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ao_migration] torchvision: torch.quantization -> torch.ao.quantization #4551

wants to merge 1 commit into from

Conversation

z-a-f
Copy link

@z-a-f z-a-f commented Oct 6, 2021

Summary:
This changes the imports in the pytorch/vision to include the new import locations.

codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'

Differential Revision: D31302368

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
e5253e8 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 821ba3697d549e88e39fe1e60fcda56e420a9d22
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from ffb8ebe to e5253e8 Compare October 6, 2021 19:23
z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
ff2eec3 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: f35bb03baa5fe7b6fa8a0d38eabf54d1e7c864f5
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from e5253e8 to ff2eec3 Compare October 6, 2021 19:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
63516bf 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 562b28149128821a94a6b38b4381222140f8fbfd
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from ff2eec3 to 63516bf Compare October 6, 2021 19:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
33821b3 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 2a5440df364bdd77a5a1cb7f9e4991fc546edacf
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from 63516bf to 33821b3 Compare October 6, 2021 19:31
z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
c68d90f 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: c945b8d677a84b10f042458adb5ed6c0c255bc3d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from 33821b3 to c68d90f Compare October 6, 2021 19:32
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
bbc7a26 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 7fb2e62158ff026891aabb846fdbaaaca4106015
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from c68d90f to bbc7a26 Compare October 6, 2021 20:29
z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
3c8ead3 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 638bb31a1d6082defa1e35b207158af2b9191686
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from bbc7a26 to 3c8ead3 Compare October 6, 2021 20:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

z-a-f pushed a commit to z-a-f/vision that referenced this pull request Oct 6, 2021
@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
6a67d52 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: f60adcc1baf67a79c718ecbd7beb7f8000692056
@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from 3c8ead3 to 6a67d52 Compare October 6, 2021 20:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

@facebook-github-bot
[ao_migration] torchvision: torch.quantization -> torch.ao.quantizati…
de0c50f 
…on (pytorch#4551)

Summary:
Pull Request resolved: pytorch#4551

This changes the imports in the `pytorch/vision` to include the new import locations.

```
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'
```

Differential Revision: D31302368

fbshipit-source-id: 832f5e3790e3888931d4708fea224ce7e7a335c2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31302368

@z-a-f z-a-f force-pushed the export-D31302368-to-fbsync branch from 6a67d52 to de0c50f Compare October 6, 2021 20:36
vkuzo
vkuzo reviewed Oct 6, 2021
View reviewed changes
references/classification/train_quantization.py
import datetime
import os
import time
import copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be nice to separate unrelated changes into a separate PR, there are a lot in this PR

@NicolasHug NicolasHug mentioned this pull request Oct 7, 2021
Merged
@NicolasHug
Copy link
Member

There are a few things going on:

we can't merge this PR because it's exported against the fbsync branch which is protected. We need a PR against the main branch.

There are a bunch of conflicts due to the recent black-formatting (and sorted import order) that we have recently enabled. I think this PR / diff is based on a version where these changes weren't included in fbcode at the time (The corresponding diff is https://www.internalfb.com/diff/D31380329) and was only landed yesterday.

Sorry about all this confusion @z-a-f , our torchvision workflow is quite different from that of pytorch core as we use GitHub as the only source of truth.

Hoping that this will help moving things further, I opened #4554 which I think does the same changes intended here. Let's move the discussion in #4554, as this PR here will not be actionable. Please feel free to directly push to #4554

@NicolasHug NicolasHug closed this Oct 7, 2021
@z-a-f
Copy link
Author

z-a-f commented Oct 7, 2021

OK, I am closing the internal diff as well, assuming that @NicolasHug will take care of the AO migration within the torchvision :)

@NicolasHug
Copy link
Member

@z-a-f my intent with #4554 was to ease the Pr submission process, but if there are any additional changes I believe I might not be the best suited person for this. I have zero knowledge of the ao module.

Would you mind following up on my comment in #4554, namely:

I just did some brutal sed -i "s/.../..." so I might have done something wrong. @z-a-f please double-check that these are the intended changes :)

and

@z-a-f , are the functions / classes in toch.ao.quantization exactly the same as in torch.quantization, or should we expect some different results? Some of the changes here are editing the training references, so we need to make sure that everything still works as before in terms of model accuracy etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo left review comments

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

@datumbox datumbox Awaiting requested review from datumbox

@pmeier pmeier Awaiting requested review from pmeier

Assignees

No one assigned

Labels

ciflow/default cla signed fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@z-a-f @facebook-github-bot @NicolasHug @vkuzo