Skip to content

Cleanup prototype kernel dispatchers #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

Cleanup prototype kernel dispatchers #5417

merged 2 commits into from
Feb 14, 2022

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Feb 14, 2022

This PR is a follow-up to #5407 and does two things:

  1. It ports all the remaining stable kernels to the prototype kernels
  2. It clarifies the docstring of the dispatchers, since ADDME could also mean that an implementation needs to be added, which is not the case.

@pmeier pmeier requested a review from datumbox February 14, 2022 07:27
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 14, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 5e5c602 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pmeier.

@datumbox datumbox merged commit fd5109a into pytorch:main Feb 14, 2022
@pmeier pmeier deleted the port-kernels branch February 14, 2022 09:08
facebook-github-bot pushed a commit that referenced this pull request Feb 16, 2022
@kazhang @facebook-github-bot
[fbsync] Cleanup prototype kernel dispatchers (#5417)
d646c40 
Summary:
* add all legacy kernels

* clarify dispatcher docstrings

Reviewed By: sallysyw

Differential Revision: D34265744

fbshipit-source-id: f1654ce8796ea0e5206448234a3707b250ae7b96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed enhancement module: transforms prototype

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmeier @facebook-github-bot @datumbox