extract common utils for prototype transform tests #6552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Sep 9, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
Reviewed By: YosuaMichael Differential Revision: D39426992 fbshipit-source-id: 3cb21ec8f82b5ccbd5184dbbed62fd07c84f65cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title. The new module
prototype_common_utils.pynow contains all functions for feature creation, comparison. Plus, I've unifiedArgsKwargsfromtest_prototype_transforms_consistency.pywithSampleInputfromtest_prototype_transforms_functionals.py.I've done this in preparation for #5879, but this is a good change whether or not we go for the other PR in the end. With this we have all common utilities in one place rather than scattered and accidentally reinventing the wheel.