Skip to content

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Nov 14, 2023

This addresses #8100. The offending PR was reverted: The offending PR was reverted: pytorch/pytorch#113023 (comment). However, one of pkg_resources (deprecated package that comes with setuptools) or packaging is still required: https://github.com/pytorch/pytorch/blame/a1e3c501652101e8b37baac62216db7ca22c9923/torch/torch_version.py#L22-L29

Thus, let's just install packaging as part of the regular dev requirements to avoid the warning.

cc @seemethere

Copy link

pytorch-bot bot commented Nov 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8115

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 3ea0443 with merge base 7b4681a (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, approving but just to make sure: this is only a dev dependency (not runtime), right?

@pmeier
Copy link
Contributor Author

pmeier commented Nov 17, 2023

Unfortunately, packaging is actually a runtime dependency 😞 See pytorch/pytorch#113940. Thanks for pressing on this @NicolasHug! Closing this as it has to be fixed upstream.

@pmeier pmeier closed this Nov 17, 2023
@pmeier pmeier deleted the packaging branch November 17, 2023 09:48
@albanD
Copy link

albanD commented Nov 21, 2023

Does this mean that vision will rely on the vendored version of packaging within PyTorch? Or this was just a pure PyTorch issue that needed a workaround here for CI to be gren?

@pmeier
Copy link
Contributor Author

pmeier commented Nov 21, 2023

@albanD We hit a problem since part of our test suite errors on warnings. We don't need packaging, but the error was coming from inside torch. So, with my PR on core merged, I'll revert #8100 when tomorrows nightly release arrives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants