Remove viable strict workflow #8676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8676
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Unrelated FailureAs of commit 9c6d14e with merge base f0ed07d ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
added a commit
to pytorch/test-infra
that referenced
this pull request
Oct 9, 2024
I discovered that you don't actually have to check out the test-infra repository because it's already there? Docs: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables Only available for composite actions unfortunately Testing: https://github.com/pytorch/pytorch/actions/runs/11225822033?pr=137454 (actual pushing is commented out) There are also two fetch_latest_green_commit.py scripts in test-infra so I merged them and chose the location in tools/scripts. The logic between the two is pretty much the same. gitutils was copied from .github/scripts (but we don't need much of it) There's also a reusable workflow update-viablestrict and a composite action update-viablestrict. The composite action is usually used, but there are some differences between the two, and vision uses the reusable workflow so I can't get rid of it just yet. (idk how much they care tho, I don't vision has succeeded updating viable/strict in a while). I also can't just make the reusable action call the composite action since the workflow uses an ssh key to check out but the action uses a token --- If pytorch/vision#8676 gets merged, I'll remove the reusable workflow
NicolasHug
approved these changes
Oct 11, 2024
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
clee2000
added
the
other
clee2000
added a commit
to pytorch/test-infra
that referenced
this pull request
Oct 17, 2024
Only used in pytorch/vision, which was removed in pytorch/vision#8676 The composite action version still exists
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Reviewed By: vmoens Differential Revision: D68021981 fbshipit-source-id: 41fb238fc098c76a4ddd4c76cf49bda37bb93ce6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch hasn't been updated in 8 months, and it's using a weird version of the viable strict update that I want to get rid of