Skip to content

Address internal linters #9201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

Address internal linters #9201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bccdb
Address internal linters
NicolasHug Sep 1, 2025
1fc4ad3
Merge branch 'main' into internallinters
AntoineSimoulin Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions torchvision/csrc/ops/cuda/nms_kernel.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ __global__ void nms_kernel_impl(
double iou_threshold,
const T* dev_boxes,
unsigned long long* dev_mask) {
const int row_start = blockIdx.y;
const int col_start = blockIdx.x;
const auto row_start = blockIdx.y;
const auto col_start = blockIdx.x;

if (row_start > col_start)
return;
Expand All @@ -59,7 +59,7 @@ __global__ void nms_kernel_impl(
__syncthreads();

if (threadIdx.x < row_size) {
const int cur_box_idx = threadsPerBlock * row_start + threadIdx.x;
const auto cur_box_idx = threadsPerBlock * row_start + threadIdx.x;
const T* cur_box = dev_boxes + cur_box_idx * 4;
int i = 0;
unsigned long long t = 0;
Expand All @@ -84,7 +84,7 @@ __global__ static void gather_keep_from_mask(
// Taken and adapted from mmcv
// https://github.com/open-mmlab/mmcv/blob/03ce9208d18c0a63d7ffa087ea1c2f5661f2441a/mmcv/ops/csrc/common/cuda/nms_cuda_kernel.cuh#L76
const int col_blocks = ceil_div(n_boxes, threadsPerBlock);
const int thread_id = threadIdx.x;
const auto thread_id = threadIdx.x;

// Mark the bboxes which have been removed.
extern __shared__ unsigned long long removed[];
Expand Down
Loading