-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Fixed Caltech-101 and Caltech-256 broken links with the official ones #9205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9205
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3bb37f4 with merge base 7bd8066 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @hrsvrn! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
torchvision/datasets/caltech.py
Outdated
extracted_dir = os.path.join(self.root, "caltech-101") | ||
extract_archive(os.path.join(extracted_dir, "101_ObjectCategories.tar.gz"), self.root) | ||
extract_archive(os.path.join(extracted_dir, "Annotations.tar.gz"), self.root) # Note: Annotations is now also .tar.gz in the new archive | ||
shutil.rmtree(extracted_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we re-use the code from other datasets? For instance in "mnist.py" to extract all possible subdirectories?
for gzip_file in os.listdir(gzip_folder):
if gzip_file.endswith(".gz"):
extract_archive(os.path.join(gzip_folder, gzip_file), self.raw_folder)
shutil.rmtree(gzip_folder)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that works as well.. I will change this one :)
Should i still work on this or not? |
@AntoineSimoulin any updates on this one? |
Hey @hrsvrn |
@hrsvrn yes please let's make it to the finish line for this PR! I just adjusted the linting but I think we are pretty close now! @JonasKlotz I will credit you when merging this PR to acknowledge your suggested changes in #9098! |
Hey @AntoineSimoulin and @JonasKlotz sorry for the late reply. |
Hey @AntoineSimoulin! You merged this PR, but no labels were added. |
Context
With reference to PR #9192
Issue
The google drive links are broken and does not download
How to use?
Fix
Replaced the deadlinks with the official CalTech Repository site downloads and made sure that the data downloading is fixed accordingly