Skip to content

Updating decode_gif to default to DISPOSE_DO_NOT to fix animated gif loading #9241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

Updating decode_gif to default to DISPOSE_DO_NOT to fix animated gif loading #9241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0099a
Updating decode_gif to default to DISPOSE_DO_NOT when a frame has dis…
sg3-141-592 Oct 11, 2025
a3054dc
lint
AntoineSimoulin Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions torchvision/csrc/io/image/cpu/decode_gif.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,16 @@ torch::Tensor decode_gif(const torch::Tensor& encoded_data) {
// - the current image is smaller than the canvas, hence exposing its pixels
// The "background" disposal method means that the current canvas should be
// set to the background color.
// We only support these 2 modes and default to "background" when the
// disposal method is unspecified, or when it's set to "DISPOSE_PREVIOUS"
// We only support these 2 modes and default to DISPOSE_DO_NOT when the
// disposal method is unspecified, or when it's set to DISPOSE_PREVIOUS
// which according to GIFLIB is not widely supported.
// (https://giflib.sourceforge.net/whatsinagif/animation_and_transparency.html).
if (i > 0 && gcb.DisposalMode == DISPOSE_DO_NOT) {
// This is consistent with default behaviour in the majority of web browsers
// and image libraries like Pillow.
if (i > 0 &&
(gcb.DisposalMode == DISPOSAL_UNSPECIFIED ||
gcb.DisposalMode == DISPOSE_DO_NOT ||
gcb.DisposalMode == DISPOSE_PREVIOUS)) {
out[i] = out[i - 1];
} else {
// Background. If bg wasn't defined, it will be (0, 0, 0)
Expand Down