Added mse_loss and mse_loss_backward lowering. #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlibenzi
requested changes
Oct 16, 2019
torch_xla/csrc/ops/mse_loss.cpp
Outdated
| return ss.str(); | ||
| } | ||
|
|
||
| ReductionMode MseLoss::GetXlaReductionMode(xla::int64 reduction) { |
There was a problem hiding this comment.
Do not copy this 😄
There is a perfectly good version in L1Loss...
torch_xla/csrc/ops/mse_loss.h
Outdated
|
|
||
| xla::int64 reduction() const { return reduction_; } | ||
|
|
||
| static ReductionMode GetXlaReductionMode(xla::int64 reduction); |
There was a problem hiding this comment.
Remove and use the L1Loss one.
dlibenzi
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.