Parse json comment in new API. #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailzhang
force-pushed
the
json_comment
branch
from
53819ac to
0e97807
Compare
dlibenzi
requested changes
Feb 28, 2020
ailzhang
force-pushed
the
json_comment
branch
from
0e97807 to
d80063b
Compare
dlibenzi
reviewed
Feb 28, 2020
ailzhang
force-pushed
the
json_comment
branch
from
d80063b to
2acfa4f
Compare
dlibenzi
reviewed
Feb 28, 2020
ailzhang
force-pushed
the
json_comment
branch
from
2acfa4f to
c559bb7
Compare
dlibenzi
approved these changes
Feb 28, 2020
ailzhang
force-pushed
the
json_comment
branch
from
c559bb7 to
99bf081
Compare
dlibenzi
approved these changes
Feb 28, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 29, 2020
…33908) Summary: This PR prepares us to allow XLA use `XLAPreAutograd` to override compound ops. To do this we'll need to pass all ops, with additional infomation about whether it's compound or not for XLA to parse. Companion PR: pytorch/xla#1698 Pull Request resolved: #33908 Differential Revision: D20149585 Pulled By: ailzhang fbshipit-source-id: a93140e8a34548fcabcea454386d15df58177c1d
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…ytorch#33908) Summary: This PR prepares us to allow XLA use `XLAPreAutograd` to override compound ops. To do this we'll need to pass all ops, with additional infomation about whether it's compound or not for XLA to parse. Companion PR: pytorch/xla#1698 Pull Request resolved: pytorch#33908 Differential Revision: D20149585 Pulled By: ailzhang fbshipit-source-id: a93140e8a34548fcabcea454386d15df58177c1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: pytorch/pytorch#33908