Handles additional args for leaky_relu_backward. #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlibenzi
requested changes
Feb 28, 2020
| at::Scalar negative_slope, | ||
| bool self_is_result) { | ||
| XLA_FN_COUNTER("xla::"); | ||
| XLA_CHECK(!self_is_result || negative_slope.to<double>() > 0.0) |
There was a problem hiding this comment.
You know my thought in chaing pytorch messages 😉
There was a problem hiding this comment.
Haha I know, but I feel this message is useful to tell users what happened and what to do? :P
|
Merging for now to unblock master breakage. :P Will open follow up PRs to address comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed after pytorch/pytorch#33639 lands