Skip to content

Split gradient reduction into a separate utility API. #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

Split gradient reduction into a separate utility API. #1709

merged 1 commit into from
Mar 2, 2020

Conversation

dlibenzi
Copy link
Collaborator

@myleott @taylanbil
With this one can do, instead of this:

xm.optimizer_step(optimizer)

This:

xm.reduce_gradients(optimizer)
my_clip_gradients(optimizer)
optimizer.step()

@dlibenzi dlibenzi requested a review from ailzhang February 29, 2020 18:14
@ailzhang ailzhang merged commit cbcd25a into master Mar 2, 2020
@ailzhang ailzhang deleted the split_reducegrad branch March 2, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ailzhang ailzhang ailzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlibenzi @ailzhang