Skip to content

Use size_and_strides_ data structure. #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021
+6 −5
Merged

Use size_and_strides_ data structure. #2685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5001fa4
Use size_and_strides_ data structure.
Dec 14, 2020
aef3978
Delete .torch_pin
ailzhang Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions torch_xla/csrc/tensor_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,16 @@ void XLATensorImpl::SetupSizeProperties() {
// Fill up the basic dimension data members which the base class
// implementation uses in its APIs.
auto shape = tensor_.shape();
sizes_.clear();
c10::SmallVector<int64_t, 5> updated_sizes;
numel_ = 1;
for (auto dim : shape.get().dimensions()) {
sizes_.push_back(dim);
updated_sizes.push_back(dim);
numel_ *= dim;
}
strides_.clear();
for (auto stride : ComputeArrayStrides(shape.get().dimensions())) {
strides_.push_back(stride);
sizes_and_strides_.set_sizes(updated_sizes);
auto updated_strides = ComputeArrayStrides(shape.get().dimensions());
for (int i = 0; i < updated_strides.size(); i++) {
sizes_and_strides_.stride_at_unchecked(i) = updated_strides[i];
}
generation_ = generation;
}
Expand Down