Add std abd var lowering with correction #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdhirsh
added a commit
that referenced
this pull request
Apr 23, 2021
bdhirsh
added a commit
that referenced
this pull request
May 3, 2021
bdhirsh
added a commit
that referenced
this pull request
May 4, 2021
bdhirsh
added a commit
that referenced
this pull request
May 4, 2021
bdhirsh
added a commit
that referenced
this pull request
May 10, 2021
bdhirsh
added a commit
that referenced
this pull request
May 10, 2021
* use in-tree public codegen API. * use in-tree public codegen API. * use in-tree public codegen API. * use in-tree public codegen API. * updated the docs to mention new codegen * stop pinning to feature branch * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * update list of ops to be in sync with master * add clamp ops to xla_native_functions.yaml
bdhirsh
added a commit
that referenced
this pull request
May 11, 2021
bdhirsh
added a commit
that referenced
this pull request
May 11, 2021
bdhirsh
added a commit
that referenced
this pull request
May 11, 2021
bdhirsh
added a commit
that referenced
this pull request
May 11, 2021
bdhirsh
added a commit
that referenced
this pull request
May 11, 2021
bdhirsh
added a commit
that referenced
this pull request
May 12, 2021
bdhirsh
added a commit
that referenced
this pull request
May 12, 2021
bdhirsh
added a commit
that referenced
this pull request
May 12, 2021
bdhirsh
added a commit
that referenced
this pull request
May 19, 2021
bdhirsh
added a commit
that referenced
this pull request
May 19, 2021
bdhirsh
added a commit
that referenced
this pull request
May 19, 2021
bdhirsh
added a commit
that referenced
this pull request
May 19, 2021
bdhirsh
added a commit
that referenced
this pull request
May 24, 2021
bdhirsh
added a commit
that referenced
this pull request
May 24, 2021
bdhirsh
added a commit
that referenced
this pull request
May 26, 2021
* use in-tree public codegen API. * use in-tree public codegen API. * use in-tree public codegen API. * stop pinning to feature branch * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * use in-tree public codegen API. * stop pinning to feature branch * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * updated torch pin * fix missing ops in yaml * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * make codegen backend-agnostic, except for CPU fallbacks * remove logging * fix straggler AtenXlaType ops * lint * rename aten_xla_type.h -> XLANativeFunctions.h * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * update torch_pin after the file rename * remove logging info from yaml * lint * doc fix * rebase fix * remove torch pin
bdhirsh
added a commit
that referenced
this pull request
May 26, 2021
bdhirsh
added a commit
that referenced
this pull request
May 26, 2021
bdhirsh
added a commit
that referenced
this pull request
May 27, 2021
#2962) * use in-tree public codegen API. * use in-tree public codegen API. * use in-tree public codegen API. * stop pinning to feature branch * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * use in-tree public codegen API. * stop pinning to feature branch * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * updated torch pin * fix missing ops in yaml * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * make codegen backend-agnostic, except for CPU fallbacks * remove logging * rename aten_xla_type.h -> XLANativeFunctions.h * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * update torch_pin after the file rename * remove logging info from yaml * make codegen backend-agnostic, except for CPU fallbacks * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * use codegen'd inplace kernels, and delete manually written inplace kernels * fix test change * lint * remove accidentally committed yaml changes * remove torch pin
bdhirsh
added a commit
that referenced
this pull request
May 27, 2021
bdhirsh
added a commit
that referenced
this pull request
May 27, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 10, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 10, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 25, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 25, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 26, 2021
* use in-tree public codegen API. * use in-tree public codegen API. * stop pinning to feature branch * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * use in-tree public codegen API. * stop pinning to feature branch * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * updated torch pin * fix missing ops in yaml * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * make codegen backend-agnostic, except for CPU fallbacks * remove logging * rename aten_xla_type.h -> XLANativeFunctions.h * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * update torch_pin after the file rename * remove logging info from yaml * make codegen backend-agnostic, except for CPU fallbacks * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * use codegen'd inplace kernels, and delete manually written inplace kernels * fix test change * lint * make codegen backend-agnostic, except for CPU fallbacks * rename aten_xla_type.h -> XLANativeFunctions.h * use codegen'd inplace kernels, and delete manually written inplace kernels * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * use a boxed CPU fallback kernel * remove AtenXlaType from straggler ops * fix failing tests * formatting + test fix * fix overload naming for fallback, made calling it require a bit less boilerplate * fix name overloads for boxed fallback * reference the boxed fallback in aten_cpu_fallback.h instead of aten_xla_type_default.h * fix accidental diff * revert accidental yaml change * remove accidentally commited file * update boxed fallback API usage * remove accidentally committed file * lint * fix issue with calling XLA_COUNTER macro from boxed fallback * lint * better comment * minor pr feedback * add boxed fallback call to 2 new ops * remove to_cpu() from yaml, _to_cpu is the right one * remove torch pin
bdhirsh
added a commit
that referenced
this pull request
Jun 29, 2021
bdhirsh
added a commit
that referenced
this pull request
Jun 29, 2021
bdhirsh
added a commit
that referenced
this pull request
Jul 6, 2021
bdhirsh
added a commit
that referenced
this pull request
Jul 6, 2021
JackCaoG
added a commit
that referenced
this pull request
Jul 9, 2021
* use in-tree public codegen API. * use in-tree public codegen API. * stop pinning to feature branch * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * use in-tree public codegen API. * stop pinning to feature branch * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * updated torch pin * remove torch_pin file before merging. preemptively update yaml to incorporate #2891 * make codegen backend-agnostic, except for CPU fallbacks * remove logging * rename aten_xla_type.h -> XLANativeFunctions.h * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * update torch_pin after the file rename * remove logging info from yaml * make codegen backend-agnostic, except for CPU fallbacks * rename aten_xla_type.h -> XLANativeFunctions.h * fix rename, delete aten_xla_type.h * use codegen'd inplace kernels, and delete manually written inplace kernels * fix test change * lint * make codegen backend-agnostic, except for CPU fallbacks * rename aten_xla_type.h -> XLANativeFunctions.h * use codegen'd inplace kernels, and delete manually written inplace kernels * [WIP] remove bridge:: api from codegen. Start auto-gen'ing out/inplace kernels when possible * fix accidental diff * revert accidental yaml change * remove accidentally commited file * update boxed fallback API usage * remove accidentally committed file * lint * remove to_cpu() from yaml, _to_cpu is the right one * add XLANativeFunctions:: prefix to straggler ops * pass aten_xla_type.cpp to codegen to check for missing kernels. Get codegen to stop build on error * update torch pin * fix missing method * lint and fix missing kernel * Delete .torch_pin Co-authored-by: JackCaoG <59073027+JackCaoG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch pr pytorch/pytorch#50903. This is to fix #2890