Skip to content

Revert "Revert "Start XRT server in a separate process in CircleCI CPU test"" #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Revert "Revert "Start XRT server in a separate process in CircleCI CPU test"" #3584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb95287
Revert "Revert "Start XRT server in a separate process in CircleCI CP…
JackCaoG May 19, 2022
8c13b0e
Update common.sh
JackCaoG May 19, 2022
298c118
Remove pjrt test for now
JackCaoG May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .circleci/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,16 @@ function run_torch_xla_tests() {
export GPU_NUM_DEVICES=2
else
export XRT_DEVICE_MAP="CPU:0;/job:localservice/replica:0/task:0/device:XLA_CPU:0"
XLA_PORT=$(shuf -i 40701-40999 -n 1)
export XLA_PORT=$(shuf -i 40701-40999 -n 1)
export XRT_WORKERS="localservice:0;grpc://localhost:$XLA_PORT"
fi
export PYTORCH_TESTING_DEVICE_ONLY_FOR="xla"

pushd $XLA_DIR
if [[ ! -z "${XLA_PORT}" ]]; then
echo "Starting GRPC server"
python torch_xla/core/xrt_run_server.py --port $XLA_PORT --restart
fi
echo "Running Python Tests"
./test/run_tests.sh
# only run test_autocast for cpu and gpu on circleCI.
Expand All @@ -141,6 +145,11 @@ function run_torch_xla_tests() {
fi
fi

# clear the XRT server before cpp test since CPP test won't run torch_xla's
# __init__.py hence will force a in process server. Note that we can not use
# -m here since we are in the XLA dir. Trying to run the torch_xla module
# from this dir will result in a `version.py` missing error.
python torch_xla/core/xrt_run_server.py --stop
pushd test/cpp
echo "Running C++ Tests"
./run_tests.sh
Expand Down
1 change: 0 additions & 1 deletion test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ function run_all_tests {
# TODO: enable this test after tf update, currently optimization_barrier does not
# work on CPU.
# run_test python3 "$CDIR/test_checkpoint.py"
run_pjrt python3 "$CDIR/test_operations.py" "$@" --verbosity=$VERBOSITY
run_test python3 "$CDIR/test_mp_replication.py"
run_test python3 "$CDIR/test_mp_all_to_all.py"
run_test python3 "$CDIR/test_mp_collective_permute.py"
Expand Down