Skip to content

Rename SymbolicIntNode to SymIntNodeImpl #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2022
Merged

Rename SymbolicIntNode to SymIntNodeImpl #3793

merged 2 commits into from
Jul 28, 2022

Conversation

@miladm
Copy link
Collaborator

@miladm miladm commented Jul 28, 2022

Rename SymbolicIntNode to SymIntNodeImpl.

This change unblocks PyTorch/XLA HEAD that broke due to upstream changes this morning pytorch/pytorch#82350

@miladm miladm requested review from JackCaoG and Krovatkin July 28, 2022 21:31
@miladm miladm self-assigned this Jul 28, 2022
@miladm miladm added the dynamism Dynamic Shape Features label Jul 28, 2022
@miladm miladm added this to the Dynamic Shape milestone Jul 28, 2022
yeounoh
yeounoh approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Krovatkin
Krovatkin approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yeounoh yeounoh mentioned this pull request Jul 28, 2022
Closed
@JackCaoG
Copy link
Collaborator

Build passed, I will merge this to unblock the master.

@JackCaoG JackCaoG merged commit 787b846 into master Jul 28, 2022
@miladm miladm mentioned this pull request Jul 28, 2022
Closed
@wonjoo-wj wonjoo-wj mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackCaoG JackCaoG Awaiting requested review from JackCaoG

2 more reviewers

@Krovatkin Krovatkin Krovatkin approved these changes

@yeounoh yeounoh yeounoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miladm miladm

Labels

dynamism Dynamic Shape Features

Projects

None yet

Milestone

Dynamic Shape

Development

Successfully merging this pull request may close these issues.

5 participants

@miladm @JackCaoG @Krovatkin @yeounoh